Ai_Agent

Ai_Agent closed issue MilkyShots/MilkyShots#44

2026-07-15 18:18:40 +00:00

Fix Album's asset visibility

Ai_Agent commented on issue MilkyShots/MilkyShots#44

2026-07-15 18:18:37 +00:00

Fix Album's asset visibility

Visibility Architecture: Decision & Analysis

Discussed with @REDCODE — July 15, 2026

Conclusion: Rejecting the Additive Rule

After analyzing the entire codebase and discussing the…

Ai_Agent commented on issue MilkyShots/MilkyShots#93

2026-07-15 16:37:42 +00:00

Add visibility levels (Public/Protected/Private) to Person, Album, and Asset

Status check against current codebase — ~90% complete

✅ Phase A — Enum + Entities (DONE)

EVisibility.cs created in Butter/Types/
All three models (Person, Album, Asset)…

Ai_Agent commented on issue MilkyShots/MilkyShots#44

2026-07-15 16:34:41 +00:00

Fix Album's asset visibility

Visibility Audit Report: Issue #44 vs Current Implementation

Issue Thesis

Assets inside an album should inherit the album's visibility — "you only need permission over album to see…

Ai_Agent commented on pull request MilkyShots/MilkyShots#127

2026-07-15 15:46:56 +00:00

feat: frontend alignment for #106 auth redesign — Maintainer role, visibility UI, user data

Changes from latest review session (5 commits)

Backend fixes

UserController.GetAll — changed ?? EAccessLevel.Admin fallback to ?? EAccessLevel.User (safer default behind…

Ai_Agent commented on pull request MilkyShots/MilkyShots#127

2026-07-15 14:14:26 +00:00

feat: frontend alignment for #106 auth redesign — Maintainer role, visibility UI, user data

PR #127 Review

Overview

39 files, +1217 / -159. Introduces the Maintainer role, data visibility enforcement at the mapper level, maintainer-to-cosplayer assignment, centralized role…

Ai_Agent opened issue MilkyShots/MilkyShots#128

2026-07-15 10:24:06 +00:00

Multi-select enhancements: merge, visibility, linking, and card colors

Ai_Agent created pull request MilkyShots/MilkyShots#127

2026-07-15 09:21:32 +00:00

WIP: feat: frontend alignment for #106 auth redesign — Maintainer role, visibility UI, user data

Ai_Agent opened issue MilkyShots/MilkyShots#126

2026-07-14 19:34:42 +00:00

Add unit testing infrastructure and initial test coverage for Lactose backend

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in 0673017 — both methods now use switch expressions.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in a449c79 — EAccessLevel enum replaces bool parameter. Admin sees all, Curator sees own deleted+non-deleted, Maintainer/User see non-deleted only + visibility filter.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in 9323111 — Maintainer can now see Visibility field.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in 0673017 — same.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in c64c194 — same scoping applied to SearchQuery.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in 0673017 — switched to switch expression.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in c64c194 — Maintainer now sees Public + Protected + persons they maintain, not all persons.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

MediaController already passes user.AccessLevel to the media repository. The repository handles visibility filtering for Maintainer (same as User: Public + Protected + own uploads). Person-level maintainer override for media serving requires the asset→album→person chain check which would need PersonRepository injection — deferred.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in 08c3890 — same.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in 08c3890 — now uses PagedParametersDto.MaxPageSize const instead of hardcoded 150.

Ai_Agent commented on pull request MilkyShots/MilkyShots#125

2026-07-14 17:13:25 +00:00

feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Fixed in bbb2ed8 — default changed to EVisibility.Private.