Files
MrFastwind 4d6f162b8f fix: code quality, memory safety, and install improvements
Critical fixes:
- Fix Dockerfile: reorder stages so frontend assets embed into Go binary
- Fix Go version 1.25 (nonexistent) to 1.24 across Dockerfile, go.mod, CI
- Add graceful game server shutdown on SIGTERM/SIGINT
- Order startup tasks: updates complete before auto-start
- Fix TOCTOU race in UpdateSettings with atomic Update() method

Security:
- Add optional AUTH_TOKEN bearer auth middleware on API/WS routes
- Fix path traversal in DeleteMod using filepath.Rel instead of HasPrefix
- Add input validation for IPPort, ServerParameters, ScheduledUpdate

Memory safety:
- Cap RPT buffer allocation to 64KB to prevent OOM on large logs
- Cap GetLog file read to 10MB
- Fix context cancel leak in SteamCmdManager.run()
- Remove data-raced cancel field in steamcmd.go
- Atomic file writes (write-temp-then-rename) across all managers

Reliability:
- Log save errors in ProcessManager.Stop()
- Atomic file writes prevent corruption on crash

Tests:
- Add mod_manager_test.go (12 tests: ListWorkshopMods, ListLocalMods,
  BuildUsageMap, RemoveMod, dirSize)
- Add scheduler_test.go (6 tests: Start/Stop, Refresh with empty,
  invalid, valid, and replaced cron expressions)
- Add TestRestart to server_process_test.go

CI/Docs:
- Add -race flag to go test in CI and Makefile
- Add npm lint step to CI
- Add Go/npm module caching to CI
- Update README: prerequisites, AUTH_TOKEN/GIN_MODE/SERVERS_DIR docs,
  fix manual quickstart to use make build
2026-07-25 02:47:04 +02:00

51 lines
2.0 KiB
Makefile

.PHONY: backend frontend build run clean dev test test-backend test-frontend
# Default paths for dev — override via env (absolute to avoid CWD mismatches)
SERVERFILE_DIR ?= $(abspath dev-deploy/serverfiles)
MODS_DIR ?= $(abspath dev-deploy/serverfiles/mods)
CFG_DIR ?= $(abspath dev-deploy/serverfiles/cfg)
PROFILES_DIR ?= $(abspath dev-deploy/serverfiles/profiles)
DATA_DIR ?= $(abspath dev-deploy/data)
# Server/steamcmd overrides — set to use stubs in dev
SERVER_BINARY ?= arma3server_x64
SERVER_PARAMS ?= -server -world=empty -loadMissionToMemory -noPause
STEAMCMD_PATH ?= steamcmd
backend:
cd backend && go build -o arma3-web-server ./cmd/server/
frontend:
cd frontend && npm run build
.PHONY: copyfrontend
copyfrontend:
rm -rf backend/embed/dist
mkdir -p backend/embed/dist
cp -r frontend/dist/. backend/embed/dist/
build: frontend copyfrontend backend
run:
cd backend && SERVERFILE_DIR=$(SERVERFILE_DIR) MODS_DIR=$(MODS_DIR) CFG_DIR=$(CFG_DIR) PROFILES_DIR=$(PROFILES_DIR) DATA_DIR=$(DATA_DIR) SERVER_BINARY=$(SERVER_BINARY) SERVER_PARAMS="$(SERVER_PARAMS)" STEAMCMD_PATH=$(STEAMCMD_PATH) GIN_MODE=debug go run ./cmd/server/
dev:
mkdir -p backend/embed/dist bin $(SERVERFILE_DIR) $(MODS_DIR) $(CFG_DIR) $(PROFILES_DIR) $(DATA_DIR)
test -f backend/embed/dist/dev.txt || touch backend/embed/dist/dev.txt
cp backend/internal/services/testdata/arma3server_x64 $(SERVERFILE_DIR)/
cp backend/internal/services/testdata/steamcmd bin/
cd backend && PATH=$(CURDIR)/bin:$$PATH SERVERFILE_DIR=$(SERVERFILE_DIR) MODS_DIR=$(MODS_DIR) CFG_DIR=$(CFG_DIR) PROFILES_DIR=$(PROFILES_DIR) DATA_DIR=$(DATA_DIR) SERVER_BINARY=$(SERVER_BINARY) SERVER_PARAMS="$(SERVER_PARAMS)" STEAMCMD_PATH=$(CURDIR)/bin/steamcmd GIN_MODE=debug go run ./cmd/server/ &
cd frontend && npm run dev
clean:
rm -f backend/arma3-web-server
rm -rf frontend/dist backend/embed/dist bin
test-backend:
cd backend && go test -race ./...
test-frontend:
cd frontend && npm test
test: test-backend test-frontend