MilkyShots/MilkyShots
4
0
Fork 0
Code Issues 48 Pull Requests Packages Projects Releases Wiki Activity

Standardization for logging #21

New Issue
Open
opened 2024-11-10 23:08:34 +00:00 by REDCODE · 1 comment
REDCODE commented 2024-11-10 23:08:34 +00:00
Owner
Copy Link

We should probably discuss some standards of logging, especially for the controllers, in the current state some methods will log certain data, some other do not.

We should probably discuss some standards of logging, especially for the controllers, in the current state some methods will log certain data, some other do not.
REDCODE added the enhancementquestion labels 2024-11-10 23:08:39 +00:00
REDCODE commented 2026-07-08 16:31:45 +00:00
Author
Owner
Copy Link

🤖 Automated AI-generated analysis (2026-07-08):

Not yet standardized. Some logging improvements were made in the job system:

Commit Description
744bc9e feat: improve logging and progress reporting for album/person jobs
4b0a6df fix: per-batch progress messages and counting bug in album/person jobs
e5fc1a0 chore: remove debug auth logging middleware from Program.cs

The job system has good logging (progress messages, batch counts with thousands separators). However, controller-level logging remains inconsistent across endpoints. A standardized approach could use:

  • ILogger<T> injection in all controllers
  • Consistent log levels (Info for operations, Warning for anomalies, Error for exceptions)
  • Structured logging templates for queryability

The removal of debug auth middleware (e5fc1a0) cleaned up one source of noise, but no comprehensive logging standard was adopted.

🤖 *Automated AI-generated analysis (2026-07-08):* **Not yet standardized. Some logging improvements were made in the job system:** | Commit | Description | |---|---| | `744bc9e` | feat: improve logging and progress reporting for album/person jobs | | `4b0a6df` | fix: per-batch progress messages and counting bug in album/person jobs | | `e5fc1a0` | chore: remove debug auth logging middleware from Program.cs | The job system has good logging (progress messages, batch counts with thousands separators). However, controller-level logging remains inconsistent across endpoints. A standardized approach could use: - `ILogger<T>` injection in all controllers - Consistent log levels (Info for operations, Warning for anomalies, Error for exceptions) - Structured logging templates for queryability The removal of debug auth middleware (`e5fc1a0`) cleaned up one source of noise, but no comprehensive logging standard was adopted.
REDCODE added the AI Gen label 2026-07-08 16:32:39 +00:00
Ai_Agent added the area:backend label 2026-07-12 17:46:35 +00:00
Ai_Agent added this to the v1.1 - Upload, Admin Tooling & Site Quality milestone 2026-07-13 17:15:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI Gen
Autogenerated By AI
 area:auth
Authentication, JWT, refresh tokens
 area:backend
Lactose API (controllers, repos, services, models)
 area:ci
Docker, CI/CD, Gitea Actions
 area:db
EF Core, migrations, pgvector
 area:frontend
MilkStream WASM client (Blazor UI, SCSS, components)
 area:shared
Butter shared library (DTOs, enums, MIME types)
 good first issue
Good for new contributors
 Need Triage
Needs to be categorized by a Human
 page:admin-users
Admin user management (/Users)
 page:album-detail
Album detail page (/albums/{id})
 page:albums
Albums list (/albums)
 page:cosplayer-detail
Cosplayer detail page (/cosplayer/{id})
 page:cosplayers
Cosplayers list (/cosplayers)
 page:home
Home page (/)
 page:jobs
Background jobs page (/Jobs)
 page:login
Login page (/login)
 page:photos
Photos page (/photos)
 page:register
Register page (/Register)
 page:settings
Settings page (/Settings)
 page:stats
Statistics page (/Stats)
 page:user
User profile page (/User/{id})
 performance
Performance or scalability concern
 priority:high
Must fix / urgent
 priority:low
Nice to have
 priority:medium
Should fix
 type:docs
Documentation
 type:refactor
Code cleanup or refactoring
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label AI Gen area:backend enhancement question
Milestone
No items
No Milestone v1.1 - Upload, Admin Tooling & Site Quality
Projects
Clear projects
No project
Assignees
Clear assignees
Ai_Agent ale183 Fastwind mm00 REDCODE
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MilkyShots/MilkyShots#21
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?