diff --git a/NOTES.md b/NOTES.md new file mode 100644 index 0000000..393d068 --- /dev/null +++ b/NOTES.md @@ -0,0 +1,24 @@ +# Notes + +## Upstream Bug - `fetch_params.sqf` Line 158 + +**File:** `scripts/shared/fetch_params.sqf` +**Line:** 158 +**Type:** Logic bug (copy-paste error) + +The `default` case in the `switch (GRLIB_civilian_activity)` block writes to the wrong variable: + +```sqf +// Line 153-159 +switch (GRLIB_civilian_activity) do { + case 0: {GRLIB_civilian_activity = 0;}; + case 1: {GRLIB_civilian_activity = 0.5;}; + case 2: {GRLIB_civilian_activity = 1;}; + case 3: {GRLIB_civilian_activity = 2;}; + default {GRLIB_csat_aggressivity = 1;}; // BUG: should be GRLIB_civilian_activity +}; +``` + +This is a copy-paste error from the `GRLIB_csat_aggressivity` block above (lines 144-151). If the mission param `Civilians` receives an out-of-range value, enemy aggressivity gets silently overwritten instead of defaulting civilian activity. + +Present in the upstream KP Liberation repository at the same location. Not introduced by this mission's setup. diff --git a/kp_liberation_config.sqf b/kp_liberation_config.sqf index 74fa694..bfe523d 100644 --- a/kp_liberation_config.sqf +++ b/kp_liberation_config.sqf @@ -568,9 +568,9 @@ KPLIB_transportConfigs = [ ["CUP_B_CH53E_USMC", -8, [0,7.566,-3], [0,5.749,-3], [0,3.847,-3], [0,2,-3], [0,0.338,-3]], ["CUP_B_Kamaz_CDF", -6.5, [0,-0.4,0], [0,-2.6,0]], ["CUP_B_Kamaz_Open_CDF", -6.5, [0.12,0.4,0], [0.12,-1.8,0]], - ["CUP_B_Mi17_CDF", -6.5, [0,2.7,-1.5], [00,0.6,-1.5]], - ["CUP_B_Mi171Sh_ACR", -6.5, [0,2.7,-1.5], [00,0.6,-1.5]], - ["CUP_B_Mi171Sh_Unarmed_ACR", -6.5, [0,2.7,-1.5], [00,0.6,-1.5]], + ["CUP_B_Mi17_CDF", -6.5, [0,2.7,-1.5], [0,0.6,-1.5]], + ["CUP_B_Mi171Sh_ACR", -6.5, [0,2.7,-1.5], [0,0.6,-1.5]], + ["CUP_B_Mi171Sh_Unarmed_ACR", -6.5, [0,2.7,-1.5], [0,0.6,-1.5]], ["CUP_B_MI6A_CDF", -8, [0,6,-0.6], [0,4.3,-0.6], [0,2.5,-0.6], [0,0.5,-0.6], [0,-1.2,-0.6], [0,-3.1,-0.6]], ["CUP_B_MTVR_USA", -6.5, [-0.009,-0.647,0.112], [-0.054,-2.535,0.112]], ["CUP_B_MTVR_USMC", -6.5, [-0.009,-0.647,0.112], [-0.054,-2.535,0.112]], @@ -600,7 +600,7 @@ KPLIB_transportConfigs = [ ["CUP_O_Ural_Open_TKA", -6.5, [0,-0.5,0], [0,-2.5,0]], ["CUP_O_Ural_SLA", -6.5, [0,-0.5,0], [0,-2.5,0]], ["CUP_O_Ural_TKA", -6.5, [0,-0.5,0], [0,-2.5,0]], - ["CUP_O_Mi8_SLA_1", -6.5, [0,2.7,-1.5], [00,0.6,-1.5]], + ["CUP_O_Mi8_SLA_1", -6.5, [0,2.7,-1.5], [0,0.6,-1.5]], ["CUP_O_MI6A_CHDKZ", -8, [0,6,-0.6], [0,4.3,-0.6], [0,2.5,-0.6], [0,0.5,-0.6], [0,-1.2,-0.6], [0,-3.1,-0.6]], ["CUP_O_MI6A_TKA", -8, [0,6,-0.6], [0,4.3,-0.6], [0,2.5,-0.6], [0,0.5,-0.6], [0,-1.2,-0.6], [0,-3.1,-0.6]], ["CUP_O_C130J_Cargo_TKA",-10,[0,0.6,-3.76],[0,-0.9,-3.76],[0,-2.5,-3.76],[0,-4.2,-3.76],[0,2.2,-3.76],[0,3.8,-3.76],[0,5.5,-3.76]], diff --git a/presets/init_presets.sqf b/presets/init_presets.sqf index 5eafe1b..e923315 100644 --- a/presets/init_presets.sqf +++ b/presets/init_presets.sqf @@ -249,7 +249,7 @@ KPLIB_aiResupplySources = KPLIB_aiResupplySources apply {toLower _x}; Classname collections */ // All land vehicle classnames -KPLIB_allLandVeh_classes = [[], [huron_typename]] select (huron_typename isKindOf "Air");; +KPLIB_allLandVeh_classes = [[], [huron_typename]] select (huron_typename isKindOf "Air"); { KPLIB_allLandVeh_classes append _x; } forEach [