## Link to GitHub Issue or related Pull Request, if one exists #0 ## Description of change Significantly speeds up API screen capture and D3D9 screenshots saving. Two reasons for doing this: 1. We now have a 4K game (GITADORA) and existing capture code was taking multiple seconds. 2. Renewed user interest on streaming as we have a couple more companion apps in active development. **API screen capture (streaming), 1280x720:** 14.3ms -> 6.3ms per frame. Back buffer copies go to pooled `D3DPOOL_SYSTEMMEM` surfaces via `GetRenderTargetData` instead of allocating a lockable render target every frame, and TooJpeg is replaced with libjpeg-turbo (encode 9.8ms -> 3.0ms). MSAA remains unsupported **Screenshots for GITADORA arena model, across 4 screens with one of them 4K**: 4068ms -> 124ms. `D3DXSaveSurfaceToFileA` is replaced with fpng (encode 4043ms -> 76ms) and the screens encode in parallel. Dropping D3DX also removes the `d3dx9_43.dll` ... `d3dx9_24.dll` probing loop, so screenshots no longer fail outright on machines with no D3DX9 runtime installed. Screenshot surfaces are read on the present thread, so no D3D call reaches another thread for screenshots. This fixes a hang in DDR X2 introduced earlier in the branch: its device has no internal locking, and reading the surface on a pool thread while the present thread sat inside `GetRenderTargetData` left the game's own render thread deadlocked. ## Testing - **GITADORA** (arena model, D3D9Ex, 4K main plus three subscreens, windowed) with `-screenshotsub`: three sets of four screenshots, images verified correct. Completion order differs between sets, so the screens really are encoding in parallel. - **LovePlus** (KLP, plain D3D9, 768x1360): covers the inline path used by games whose image processing must not leave the present thread. - **API screen capture** through a companion app: live video correct throughout. - **Print Screen** bound as the screenshot key: the clipboard copy succeeded on every shot. - Quitting the game after capturing leaves no `IDirect3DDevice9` reference count warning, so the pooled readback surfaces are released along with the device.
187 lines
6.5 KiB
C++
187 lines
6.5 KiB
C++
#include "clipboard.h"
|
|
|
|
// GDI+ Headers
|
|
// WARNING: Must stay in this order to compile
|
|
#include <windows.h>
|
|
#include <objidl.h>
|
|
#include <gdiplus.h>
|
|
#ifdef __GNUC__
|
|
#include <gdiplus/gdiplusflat.h>
|
|
#else
|
|
#include <gdiplusflat.h>
|
|
#endif
|
|
|
|
#include <thread>
|
|
|
|
#include "util/libutils.h"
|
|
#include "util/logging.h"
|
|
#include "util/utils.h"
|
|
|
|
namespace clipboard {
|
|
namespace imports {
|
|
static bool ATTEMPTED_LOAD_LIBRARY = false;
|
|
|
|
static decltype(Gdiplus::GdiplusShutdown) *GdiplusShutdown = nullptr;
|
|
static decltype(Gdiplus::GdiplusStartup) *GdiplusStartup = nullptr;
|
|
static decltype(Gdiplus::DllExports::GdipCreateBitmapFromFile) *GdipCreateBitmapFromFile = nullptr;
|
|
static decltype(Gdiplus::DllExports::GdipCreateHBITMAPFromBitmap) *GdipCreateHBITMAPFromBitmap = nullptr;
|
|
static decltype(Gdiplus::DllExports::GdipDisposeImage) *GdipDisposeImage = nullptr;
|
|
}
|
|
|
|
void copy_image_handler(const std::filesystem::path &path) {
|
|
if (!imports::ATTEMPTED_LOAD_LIBRARY) {
|
|
imports::ATTEMPTED_LOAD_LIBRARY = true;
|
|
|
|
auto gdiplus = libutils::try_library("gdiplus.dll");
|
|
|
|
if (gdiplus) {
|
|
imports::GdiplusShutdown = (decltype(imports::GdiplusShutdown)) libutils::try_proc(
|
|
gdiplus, "GdiplusShutdown");
|
|
imports::GdiplusStartup = (decltype(imports::GdiplusStartup)) libutils::try_proc(
|
|
gdiplus, "GdiplusStartup");
|
|
imports::GdipCreateBitmapFromFile = (decltype(imports::GdipCreateBitmapFromFile)) libutils::try_proc(
|
|
gdiplus, "GdipCreateBitmapFromFile");
|
|
imports::GdipCreateHBITMAPFromBitmap = (decltype(imports::GdipCreateHBITMAPFromBitmap)) libutils::try_proc(
|
|
gdiplus, "GdipCreateHBITMAPFromBitmap");
|
|
imports::GdipDisposeImage = (decltype(imports::GdipDisposeImage)) libutils::try_proc(
|
|
gdiplus, "GdipDisposeImage");
|
|
} else {
|
|
log_warning("clipboard", "GDI+ library not found, disabling clipboard functionality");
|
|
}
|
|
}
|
|
if (!imports::GdiplusShutdown ||
|
|
!imports::GdiplusStartup ||
|
|
!imports::GdipCreateBitmapFromFile ||
|
|
!imports::GdipCreateHBITMAPFromBitmap ||
|
|
!imports::GdipDisposeImage)
|
|
{
|
|
return;
|
|
}
|
|
|
|
// print screen key leaves the OS briefly holding the clipboard, so retry
|
|
// spinning without yielding starves the thread we are waiting on and looks like a hang
|
|
bool clipboard_open = false;
|
|
for (int i = 0; i < 100; i++) {
|
|
if (OpenClipboard(nullptr)) {
|
|
clipboard_open = true;
|
|
break;
|
|
}
|
|
Sleep(5);
|
|
}
|
|
if (!clipboard_open) {
|
|
log_warning("clipboard", "failed to open clipboard");
|
|
return;
|
|
}
|
|
|
|
// Start gdiplus
|
|
Gdiplus::GdiplusStartupInput input {};
|
|
ULONG_PTR token;
|
|
imports::GdiplusStartup(&token, &input, nullptr);
|
|
|
|
// Convert the file path to a wstring and open the screenshot file
|
|
Gdiplus::GpBitmap *bitmap = nullptr;
|
|
auto status = imports::GdipCreateBitmapFromFile(path.c_str(), &bitmap);
|
|
if (status != Gdiplus::Ok) {
|
|
log_warning("clipboard", "failed to create GDI+ bitmap: {}", static_cast<uint32_t>(status));
|
|
|
|
imports::GdiplusShutdown(token);
|
|
CloseClipboard();
|
|
|
|
return;
|
|
}
|
|
|
|
// Retrieve the HBITMAP from the Bitmap object
|
|
HBITMAP hbitmap {};
|
|
status = imports::GdipCreateHBITMAPFromBitmap(bitmap, &hbitmap, 0);
|
|
if (status == Gdiplus::Ok) {
|
|
|
|
// Convert the HBITMAP to a DIB to copy to the clipboard
|
|
BITMAP bm;
|
|
GetObject(hbitmap, sizeof(bm), &bm);
|
|
|
|
BITMAPINFOHEADER info;
|
|
info.biSize = sizeof(info);
|
|
info.biWidth = bm.bmWidth;
|
|
info.biHeight = bm.bmHeight;
|
|
info.biPlanes = 1;
|
|
info.biBitCount = bm.bmBitsPixel;
|
|
info.biCompression = BI_RGB;
|
|
|
|
std::vector<BYTE> dimensions(bm.bmWidthBytes * bm.bmHeight);
|
|
auto hdc = GetDC(nullptr);
|
|
GetDIBits(hdc, hbitmap, 0, info.biHeight, dimensions.data(), reinterpret_cast<BITMAPINFO *>(&info), 0);
|
|
ReleaseDC(nullptr, hdc);
|
|
|
|
auto hmem = GlobalAlloc(GMEM_MOVEABLE, sizeof(info) + dimensions.size());
|
|
auto buffer = reinterpret_cast<BYTE *>(GlobalLock(hmem));
|
|
memcpy(buffer, &info, sizeof(info));
|
|
memcpy(&buffer[sizeof(info)], dimensions.data(), dimensions.size());
|
|
GlobalUnlock(hmem);
|
|
|
|
if (SetClipboardData(CF_DIB, hmem)) {
|
|
log_info("clipboard", "saved image to clipboard");
|
|
} else {
|
|
log_warning("clipboard", "failed to save image to clipboard");
|
|
}
|
|
} else {
|
|
log_warning("clipboard", "failed to retrieve HBITMAP from image bitmap: {}", static_cast<uint32_t>(status));
|
|
}
|
|
|
|
// Clean up after ourselves. hmem can't be deleted because it is owned by the clipboard now.
|
|
imports::GdipDisposeImage(bitmap);
|
|
|
|
imports::GdiplusShutdown(token);
|
|
|
|
CloseClipboard();
|
|
}
|
|
|
|
void copy_image(const std::filesystem::path path) {
|
|
|
|
// Create a new thread since we loop to open the clipboard
|
|
std::thread handle(copy_image_handler, std::move(path));
|
|
|
|
handle.detach();
|
|
}
|
|
|
|
void copy_text(const std::string& str) {
|
|
if (!OpenClipboard(nullptr)) {
|
|
log_warning("clipboard", "Failed to open clipboard");
|
|
return;
|
|
}
|
|
|
|
HGLOBAL mem = GlobalAlloc(GMEM_MOVEABLE, str.length() + 1);
|
|
memcpy(GlobalLock(mem), str.c_str(), str.length() + 1);
|
|
GlobalUnlock(mem);
|
|
|
|
EmptyClipboard();
|
|
SetClipboardData(CF_TEXT, mem);
|
|
CloseClipboard();
|
|
}
|
|
|
|
const std::string paste_text() {
|
|
HGLOBAL hglb;
|
|
LPSTR str;
|
|
std::string text;
|
|
|
|
// check if clipboard content is text
|
|
if (!IsClipboardFormatAvailable(CF_TEXT)) {
|
|
return text;
|
|
}
|
|
if (!OpenClipboard(nullptr)) {
|
|
log_warning("clipboard", "Failed to open clipboard");
|
|
return text;
|
|
}
|
|
|
|
hglb = GetClipboardData(CF_TEXT);
|
|
if (hglb != NULL) {
|
|
str = reinterpret_cast<LPSTR>(GlobalLock(hglb));
|
|
if (str != NULL) {
|
|
text = str;
|
|
GlobalUnlock(hglb);
|
|
}
|
|
}
|
|
CloseClipboard();
|
|
return text;
|
|
}
|
|
}
|