Samuele Lorefice REDCODE
0 Followers · 0 Following
  • Joined on 2024-01-01
Repositories
14
 Projects Packages Public Activity Starred Repositories
REDCODE commented on pull request MilkyShots/MilkyShots#91 2026-07-12 17:25:50 +00:00
Global "Search Anything" typeahead dropdown in navbar

what? Why? This should be able to accept any page starting from 0 and going up. So < 0 is the only invalid value. If the frontend is wrong in using this that should be fixed there. 0 is the first page. Everywhere.

REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 17:17:17 +00:00
efeed2b668 test: add page=0&pageSize=5 to paginated list endpoints
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 17:11:12 +00:00
efc6379bb3 test: add cleanup of regular test user in REST Client suite
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 17:07:43 +00:00
20a456591d fix: move SharedWith visibility check to client side for translatable queries
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 17:03:16 +00:00
1b301ff2c0 fix: standardize pagination to zero-based across all layers
REDCODE approved MilkyShots/MilkyShots#91 2026-07-12 16:51:47 +00:00
Global "Search Anything" typeahead dropdown in navbar
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 16:50:07 +00:00
50c58e22ff fix: restore ToAlbumPreviewDto mapper method per review feedback #91
REDCODE commented on pull request MilkyShots/MilkyShots#91 2026-07-12 16:47:25 +00:00
Global "Search Anything" typeahead dropdown in navbar

This should be kept

REDCODE suggested changes for MilkyShots/MilkyShots#91 2026-07-12 16:47:25 +00:00
Global "Search Anything" typeahead dropdown in navbar
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 16:25:03 +00:00
ad2f08698d perf: simplify ORDER BY to total count and add trigram GIN indexes
e05ab3beaf docs: document REST Client tests in AGENTS.md
48b6d4f149 perf: add partial index on Assets for visibility-aware search queries
89edf290ff refactor: project AlbumPreviewDto directly in repository with visibility-aware asset count
c77096b0f9 refactor: project PersonPreviewDto directly in repository instead of [NotMapped] entity property
Compare 5 commits »
REDCODE commented on pull request MilkyShots/MilkyShots#91 2026-07-12 14:55:22 +00:00
Global "Search Anything" typeahead dropdown in navbar

I really don't like a single property, not mapped that is reliable only in some contexts

REDCODE suggested changes for MilkyShots/MilkyShots#91 2026-07-12 14:55:22 +00:00
Global "Search Anything" typeahead dropdown in navbar
REDCODE approved MilkyShots/MilkyShots#91 2026-07-12 14:54:03 +00:00
Global "Search Anything" typeahead dropdown in navbar
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-12 14:52:31 +00:00
e333d0e9db fix: filter album count by user visibility in person search
324c1b1a17 fix: prevent duplicate @key errors across all list renderings
Compare 2 commits »
REDCODE approved MilkyShots/MilkyShots#91 2026-07-12 09:00:52 +00:00
Global "Search Anything" typeahead dropdown in navbar
REDCODE commented on pull request MilkyShots/MilkyShots#91 2026-07-12 08:59:09 +00:00
Global "Search Anything" typeahead dropdown in navbar

how social do we want this to become? We'll change this in future I guess

REDCODE commented on pull request MilkyShots/MilkyShots#91 2026-07-12 08:57:31 +00:00
Global "Search Anything" typeahead dropdown in navbar

I'll just add a note here, this is temporary and #95 should take care of this at a later stage.

REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-11 18:49:48 +00:00
ee3511c09a fix: paginate PersonRepository.SearchQuery by ID before loading albums
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-11 18:41:08 +00:00
41c262d157 fix: restore Include(p => p.Albums) in PersonRepository queries
837491fa4a fix: guard ILIKE filter in AlbumRepository.SearchQuery against null/empty query
5a2f61d261 perf: push visibility filter into SQL for PersonRepository queries
Compare 3 commits »
REDCODE pushed to feature/global-search-dropdown at MilkyShots/MilkyShots 2026-07-11 17:02:59 +00:00
851cdfa924 test: restructure WepApiTest.http with three clearly separated users