Samuele Lorefice REDCODE
  • Joined on 2024-01-01
REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Maintainer should be able to see the visibility if it's an asset assigned to a cosplayer they maintain

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Maintainer of a person should also get this value

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Visibility field is missing?

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Filtering by access level? As the other search query methods do? Maybe? Not sure.

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Maintainer OF that cosplayer can get all assets, otherwise it's like an user.

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Yes they can, if they are a maintainer of the cosplayer related to the album.

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Maintainer is missing here.

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

if we are just trying to access media, and we will have to check user being able to access the asset, this includes the user being a maintainer of the cosplayer the asset is assigned to... do we need the media repository to also get the visibility level?

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

This query needs a double check.

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

Should default to private

REDCODE commented on pull request MilkyShots/MilkyShots#125 2026-07-14 16:39:13 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

PageSize in search should default to PagedSearchDto.MaxPageSize.

REDCODE pushed to feature/106-auth-redesign at MilkyShots/MilkyShots 2026-07-14 16:13:20 +00:00
1b444dab93 feat(auth): complete Maintainer role — add PersonMaintainer checks, update controller authz, pass uploadedBy search param
REDCODE created branch feature/106-auth-redesign in MilkyShots/MilkyShots 2026-07-14 15:52:26 +00:00
REDCODE pushed to feature/106-auth-redesign at MilkyShots/MilkyShots 2026-07-14 15:52:26 +00:00
50bf0a2a78 feat(db): add migration for auth redesign — drop IsPubliclyShared/UserOwnerId/SharedWith, add Visibility, PersonMaintainer, rename OwnerId→UploadedBy
2335e8e23a feat(repos,controllers): update repositories, interfaces, controllers for auth redesign — visibility filtering, UploadedBy/Uploader rename, Maintainer support
d02a010083 feat(infra): update DbContext and mappers for auth redesign — new relationships, PersonMaintainer, conditional Visibility
6676347353 feat(models): update models for auth redesign — rename Owner→UploadedBy, drop UserOwnerId/IsPubliclyShared, add EVisibility, PersonMaintainer
c9391d840b feat(butter): update DTOs for visibility, renamed Owner→UploadedBy, removed IsPublic/Owner fields
Compare 6 commits »
REDCODE commented on issue MilkyShots/MilkyShots#79 2026-07-14 14:38:19 +00:00
Maintainer role class discussion

Superseded by #106

REDCODE closed issue MilkyShots/MilkyShots#79 2026-07-14 14:38:19 +00:00
Maintainer role class discussion
REDCODE commented on issue MilkyShots/MilkyShots#43 2026-07-14 14:37:56 +00:00
Fix User Deletion propagation

this has nothing to be done as user content will stay on user deletion (unless requested and/or separate mechanism but that will be a separate issue)

REDCODE closed issue MilkyShots/MilkyShots#43 2026-07-14 14:37:56 +00:00
Fix User Deletion propagation