Fastwind
  • Joined on 2024-09-24
Fastwind pushed to feature/rate-limit at MilkyShots/MilkyShots 2026-07-16 16:18:10 +00:00
c79ed47e41 feat: add rate limiting with configurable buckets
Fastwind created branch feature/rate-limit in MilkyShots/MilkyShots 2026-07-16 16:18:10 +00:00
Fastwind commented on issue MilkyShots/MilkyShots#136 2026-07-16 14:57:03 +00:00
CI / CD & Deployment organization

I plan to generate the accounts for the people and give them randomized strong passwords Admins considered too? Not planning to give untrusted people any power above user either. So the…

Fastwind commented on issue MilkyShots/MilkyShots#136 2026-07-16 14:43:50 +00:00
CI / CD & Deployment organization

How much do you trust your anti-spam for login tentatives? Because we both know someone will scraper the server and try until they found one password

Fastwind commented on issue MilkyShots/MilkyShots#136 2026-07-16 14:39:03 +00:00
CI / CD & Deployment organization

Registrations need to be disabled Is the first registration already handled? Is a configuration to disable registration present?

Fastwind commented on issue MilkyShots/MilkyShots#136 2026-07-16 14:37:15 +00:00
CI / CD & Deployment organization

For debugging and rollback policies, we need to be able to retrieve the same image used by the server.

The best course of action would be to build production images of both services (lactose…

Fastwind commented on issue MilkyShots/MilkyShots#128 2026-07-15 16:00:22 +00:00
Multi-select enhancements: merge, visibility, linking, and card colors

this issue clearly need to be fixed in the wording before continuing.

How are you moving X's albums to Y and losing information? If we are going to make new endpoints "merge" this will hide…

Fastwind commented on issue MilkyShots/MilkyShots#128 2026-07-15 15:28:38 +00:00
Multi-select enhancements: merge, visibility, linking, and card colors

image.png

Considering this, yes, if I have in the sources the destination, this would destroy information

Fastwind commented on issue MilkyShots/MilkyShots#128 2026-07-15 13:06:30 +00:00
Multi-select enhancements: merge, visibility, linking, and card colors

Missing explanation: Merge enpoinds, does the DestinationId need to be part of SourceId?

Is it implicit? Is it explicit?

Fastwind suggested changes for MilkyShots/MilkyShots#125 2026-07-14 19:59:48 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

in general correct, waiting for the last edits

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:38:07 +00:00
Global "Search Anything" typeahead dropdown in navbar

Keep looking above, and just follow that one

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:37:12 +00:00
Global "Search Anything" typeahead dropdown in navbar

Still if it's the server doing it, it doesn't resolve my question it's more of a yes or no to my question, followed by a new security issue in case of yes

Fastwind commented on issue MilkyShots/MilkyShots#98 2026-07-13 13:34:25 +00:00
Album/person search queries are catastrophically slow at scale (1.1M assets, 25k albums)

These queries are a disaster; could grouping be used instead of nesting queries? (At least for counting and sorting.) Also, instead of recalculating the queries every time, couldn't they be…

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:22:53 +00:00
Global "Search Anything" typeahead dropdown in navbar

it could be a public static property from the same paged class, unless you plan to have a config for that too

Fastwind suggested changes for MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

Need the other comments to be resolved before merge

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

Can we have a single const with the max PageSize, instead of using magic numbers