Fastwind
  • Joined on 2024-09-24
Fastwind suggested changes for MilkyShots/MilkyShots#125 2026-07-14 19:59:48 +00:00
feat: #106 auth/permissions redesign — 5-actor model, #93 visibility levels (backend)

in general correct, waiting for the last edits

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:38:07 +00:00
Global "Search Anything" typeahead dropdown in navbar

Keep looking above, and just follow that one

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:37:12 +00:00
Global "Search Anything" typeahead dropdown in navbar

Still if it's the server doing it, it doesn't resolve my question it's more of a yes or no to my question, followed by a new security issue in case of yes

Fastwind commented on issue MilkyShots/MilkyShots#98 2026-07-13 13:34:25 +00:00
Album/person search queries are catastrophically slow at scale (1.1M assets, 25k albums)

These queries are a disaster; could grouping be used instead of nesting queries? (At least for counting and sorting.) Also, instead of recalculating the queries every time, couldn't they be…

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:22:53 +00:00
Global "Search Anything" typeahead dropdown in navbar

it could be a public static property from the same paged class, unless you plan to have a config for that too

Fastwind suggested changes for MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

Need the other comments to be resolved before merge

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

Can we have a single const with the max PageSize, instead of using magic numbers

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

Are we sure to enable search queries to non users?

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

We could extend page size to 1000 rows if the row doesn't weight too much

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:08:51 +00:00
Global "Search Anything" typeahead dropdown in navbar

Are we sure to enable search queries to non users?

Fastwind commented on pull request MilkyShots/MilkyShots#91 2026-07-13 13:07:03 +00:00
Global "Search Anything" typeahead dropdown in navbar

It was structured to be possible to search other user, but yet again we need a defined use cases of what we want to actually do

Fastwind commented on issue MilkyShots/MilkyShots#27 2026-07-10 14:04:21 +00:00
Admin Registration On First Account

Given that we don't have setting that need to be set before the launch of the service, we can just take the first registration and set it up as admin

Fastwind commented on pull request MilkyShots/MilkyShots#77 2026-07-10 13:40:41 +00:00
fix: batch-processing subjob status reporting + redesign jobs page UI (#76)

Because DateTime happens at the return, it can be directly generated from the caller of the method instead of being made every time, even if you may not care about the time.

Fastwind commented on pull request MilkyShots/MilkyShots#77 2026-07-10 13:40:41 +00:00
fix: batch-processing subjob status reporting + redesign jobs page UI (#76)

The search may be long with a big list of jobs running; it could be favorable to use parallel access to the data structure.

Fastwind commented on pull request MilkyShots/MilkyShots#77 2026-07-10 13:40:41 +00:00
fix: batch-processing subjob status reporting + redesign jobs page UI (#76)

headers should only be used for metadata around a request working, not as actual parameters for a query, if it is needed to handle a starting time, it should be passed as part of a DTO.