MilkyShots/MilkyShots
4
0
Fork 0
Code Issues 39 Pull Requests Actions Packages Projects Releases 6 Wiki Activity

refactor: extract ViewModeToggle + query-param search #170

Merged
REDCODE merged 12 commits from feature/view-mode-toggle into develop 2026-08-20 15:10:36 +00:00
Conversation 0 Commits 12 Files Changed 6
+36 -81
Ai_Agent commented 2026-08-17 19:56:23 +00:00
Collaborator
Copy Link
Copy Source

Part of #155 (area C), closes #163.

Summary

  • Extracted the masonry/grid toggle (duplicated in Albums, AlbumDetail, CosplayerDetail) into a shared ViewModeToggle component.
  • Replaced the hand-rolled ParseSearchQuery URL parsing (in Albums and Cosplayers) with [SupplyParameterFromQuery(Name = "search")].

Changes

  • New Components/Shared/ViewModeToggle.razor (ViewMode + ViewModeChanged + optional Class).
  • Albums.razor, AlbumDetail.razor, CosplayerDetail.razor — use ViewModeToggle; removed per-page SetMasonry/SetGrid + button markup.
  • Albums.razor, Cosplayers.razor — searchQuery is now a [SupplyParameterFromQuery] property; removed ParseSearchQuery and its navigationManager inject.

Testing

  • dotnet build MilkyShots.sln passes.
Part of #155 (area C), closes #163. ## Summary - Extracted the masonry/grid toggle (duplicated in `Albums`, `AlbumDetail`, `CosplayerDetail`) into a shared `ViewModeToggle` component. - Replaced the hand-rolled `ParseSearchQuery` URL parsing (in `Albums` and `Cosplayers`) with `[SupplyParameterFromQuery(Name = "search")]`. ## Changes - New `Components/Shared/ViewModeToggle.razor` (`ViewMode` + `ViewModeChanged` + optional `Class`). - `Albums.razor`, `AlbumDetail.razor`, `CosplayerDetail.razor` — use `ViewModeToggle`; removed per-page `SetMasonry`/`SetGrid` + button markup. - `Albums.razor`, `Cosplayers.razor` — `searchQuery` is now a `[SupplyParameterFromQuery]` property; removed `ParseSearchQuery` and its `navigationManager` inject. ## Testing - `dotnet build MilkyShots.sln` passes.
Ai_Agent added 4 commits 2026-08-17 19:56:23 +00:00
feat: extract ViewModeToggle shared component 66782cacfc
feat: use ViewModeToggle and query-param search in albums page 3afa7f2834
feat: use ViewModeToggle in detail pages a5a783e8d6
refactor: supply search query from URL parameter in cosplayers page fe4e19a7de
REDCODE added 1 commit 2026-08-18 14:44:59 +00:00
Merge branch 'develop' into feature/view-mode-toggle c55ce7ac4f
REDCODE marked the pull request as ready for review 2026-08-18 14:45:17 +00:00
REDCODE added 1 commit 2026-08-19 00:37:12 +00:00
Merge branch 'develop' into feature/view-mode-toggle 887e5e0b31
REDCODE added 1 commit 2026-08-20 14:08:49 +00:00
Merge branch 'develop' into feature/view-mode-toggle f9556cd5de
REDCODE added 3 commits 2026-08-20 14:49:40 +00:00
Merge branch 'develop' into feature/view-mode-toggle 95c624aaab
fix(cosplayer-detail): base album selection on grid-loaded ids 796f485a84
chore: refresh GIT_VERSION env 6fbb98a3fd
REDCODE added 2 commits 2026-08-20 14:58:50 +00:00
fix(albums,cosplayers): restore SupplyParameterFromQuery search binding 4bc35c0625
chore: refresh GIT_VERSION env 7563450c35
REDCODE merged commit ffe37fec87 into develop 2026-08-20 15:10:36 +00:00
REDCODE deleted branch feature/view-mode-toggle 2026-08-20 15:10:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
AI Gen
Autogenerated By AI
 area:auth
Authentication, JWT, refresh tokens
 area:backend
Lactose API (controllers, repos, services, models)
 area:ci
Docker, CI/CD, Gitea Actions
 area:db
EF Core, migrations, pgvector
 area:frontend
MilkStream WASM client (Blazor UI, SCSS, components)
 area:shared
Butter shared library (DTOs, enums, MIME types)
 good first issue
Good for new contributors
 Need Triage
Needs to be categorized by a Human
 page:admin-users
Admin user management (/Users)
 page:album-detail
Album detail page (/albums/{id})
 page:albums
Albums list (/albums)
 page:cosplayer-detail
Cosplayer detail page (/cosplayer/{id})
 page:cosplayers
Cosplayers list (/cosplayers)
 page:home
Home page (/)
 page:jobs
Background jobs page (/Jobs)
 page:login
Login page (/login)
 page:photos
Photos page (/photos)
 page:register
Register page (/Register)
 page:settings
Settings page (/Settings)
 page:stats
Statistics page (/Stats)
 page:user
User profile page (/User/{id})
 performance
Performance or scalability concern
 priority:critical
Blocker / must fix immediately
 priority:high
Must fix / urgent
 priority:low
Nice to have
 priority:medium
Should fix
 type:docs
Documentation
 type:refactor
Code cleanup or refactoring
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Ai_Agent ale183 Fastwind mm00 REDCODE (Samuele Lorefice)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MilkyShots/MilkyShots#170