Fixes #76
## Part 1: Subjob status reporting fix
### Subjob status (all 4 slave jobs)
After the asset processing loop, the slave now checks `failedAssets`:
- **All failed** → `JobStatus.Fail(...)`
- **Some failed** → `JobStatus.CompleteWithErrors(...)`
- **None failed** → `JobStatus.Complete(...)`
Previously all three cases called `JobStatus.Complete(...)` unconditionally.
### Race condition fix (all 4 master Done handlers)
Replaced `failedAssets += sub.failedAssets` with `Interlocked.Add(ref failedAssets, sub.failedAssets)`.
**Files:**
- `Lactose/Jobs/PreviewJob.cs`
- `Lactose/Jobs/ThumbnailJob.cs`
- `Lactose/Jobs/MetadataJob.cs`
- `Lactose/Jobs/PHashJob.cs`
## Part 2: Jobs page UI redesign
### Unified tabbed view
- Replaced two separate sections (Current/Past) with **Active/Past tabs**
- Active tab polls live, Past tab is paginated
- Same filter/search/sort state across both tabs
### Search, filter, sort
- **Search** by job name or message (with `bi-search` icon)
- **Type filter** dropdown (`EJobType` + All)
- **Status filter** dropdown (`EJobStatus` + All)
- Results ordered by newest first
### Status summary strip
- Colored badges showing counts per status (e.g., "3 Running · 12 Succeeded · 2 Failed")
### Job type badges
- Distinct colored badges per `EJobType` (inspired by `AccessLevelBadge` on Users page)
### Mobile responsive
- **Desktop:** Full row layout with type badge, status label + dot, progress bar, elapsed, cancel, expand
- **Mobile (`d-md-none`):** Compact card with icon, name, type badge, status dot, progress bar, elapsed
- Launch jobs collapses into a single dropdown button on mobile
### Tree spacing
- Tighter padding in group headers, smaller chevron icons, reduced `ms-*` indentation
**Files:**
- `MilkStream.Client/Components/Pages/Jobs.razor` (rewritten)
- `MilkStream.Client/Components/Pages/Jobs.razor.css` (new)
- `MilkStream.Client/Components/JobRow.razor` (rewritten)
- `MilkStream.Client/Components/JobTree.razor` (updated)
## Testing needed
1. Verify the subjob status fix (see original issue)
2. Verify jobs page tabs switch correctly between Active and Past
3. Verify search/filter/sort narrows results correctly
4. Verify mobile layout at <768px width
5. Verify job tree expand/collapse still works
6. Verify launch job buttons work
7. Verify cancel button on running jobs works
REDCODE
added this to the v1.0 - Initial Release milestone 2026-07-10 10:05:27 +00:00
changes look fine, however there is a strange counting bug. A job with a single subjob that fails 12 assets, will show on the master job as 13 out of 12 failed.
changes look fine, however there is a strange counting bug. A job with a single subjob that fails 12 assets, will show on the master job as 13 out of 12 failed.
- Unified Active/Past tabbed view replacing separate sections
- Search by name/message, filter by job type and status
- Status summary strip with colored counts
- Job type badges with distinct colors per EJobType
- Status labels next to status dots
- Compact mobile card layout (d-md-none)
- Tighter tree spacing with lighter indentation
- Scoped Jobs.razor.css extracted from inline styles
Refs #76
Ai_Agent
changed title from WIP: fix: batch-processing subjobs report correct status on asset failures (#76) to fix: batch-processing subjob status reporting + redesign jobs page UI (#76)2026-07-10 10:16:11 +00:00
The Interlocked.Increment(ref failedAssets) for Failed subjobs
caused double-counting: a subjob with N/12 failed assets would
add 1 (failed subjob) + 12 (individual assets) = 13, exceeding
the total asset count. Removed the Increment since subjob's
failedAssets is already the accurate per-asset count.
Addressed the double-counting bug — removed the Interlocked.Increment(ref failedAssets) from the master Done handler in all 4 job types. The subjob's failedAssets is now the sole source of truth, so 12 failed assets in a batch = 12 counted, no more +1 for the subjob status.
Addressed the double-counting bug — removed the `Interlocked.Increment(ref failedAssets)` from the master Done handler in all 4 job types. The subjob's `failedAssets` is now the sole source of truth, so 12 failed assets in a batch = 12 counted, no more +1 for the subjob status.
- Removed job type badge spans from desktop and mobile JobRow
- Colored job-type icons instead (text-info/secondary/primary/etc)
- Desktop launch buttons use matching btn-outline-* colors per job type
- Mobile launch dropdown changed from dropup to dropdown to avoid
clipping into navbar
- Dropdown item icons colored per job type
- Add ModifiedAt (DateTime?) to JobRecord
- Auto-set on Insert/Update in repository
- Add GetChildrenModifiedSince to interface + implementation
- EF Core migration AddModifiedAtToJobRecord
- JobManager.GetChildren now accepts optional 'since' parameter
- Returns only children with LastChange/ModifiedAt > since
- Includes seenIds dedup between active and past children
- Returns response timestamp for next poll
- Controller sets x-delta-timestamp header
- JobTree polls children for all Level 0 active roots (not just expanded),
so segment progress bars update on collapsed rows too
- Add PollChildren helper to deduplicate fetch logic
- OnExpanded only stops refresh when no active roots remain
- Store UtcNow as fallback when server x-delta-timestamp is missing
- Fix segment colors: share ToCssClass between single and stacked bars,
use text-bg-* classes for proper Bootstrap 5.3 progress-bar override
- Replace status words with Bootstrap icons in child summary
(e.g. "15 Running" → "15 🔃") for compact display
- EagerFetchMissing fetches children for active roots on parameter set
so the summary never shows the placeholder
- ChildSummary returns null instead of "sub-jobs..." when not fetched
headers should only be used for metadata around a request working, not as actual parameters for a query, if it is needed to handle a starting time, it should be passed as part of a DTO.
the specific "x-delta-timestamp" is used for profiling or time synced operations
this is more of a request to select a specific group of jobs, also may be used in conjunction with a "latest", for visualizing all the jobs inside a time window (can be used for debug feature)
headers should only be used for metadata around a request working, not as actual parameters for a query, if it is needed to handle a starting time, it should be passed as part of a DTO.
the specific "x-delta-timestamp" is used for profiling or time synced operations
this is more of a request to select a specific group of jobs, also may be used in conjunction with a "latest", for visualizing all the jobs inside a time window (can be used for debug feature)
Because DateTime happens at the return, it can be directly generated from the caller of the method instead of being made every time, even if you may not care about the time.
Ttuple as return type make the code stinky because isn't cleanly hineritable. JobManager is actually a Service and it should follow the same policy of APIs so specific data structure should always be used to couple informations.
Because DateTime happens at the return, it can be directly generated from the caller of the method instead of being made every time, even if you may not care about the time.
Ttuple as return type make the code stinky because isn't cleanly hineritable. JobManager is actually a Service and it should follow the same policy of APIs so specific data structure should always be used to couple informations.
- Add ChildrenResponse DTO (Children + Since) in Butter.Dtos.Jobs
- JobManager.GetChildren returns List<JobStatusDto> only (no tuple),
active children filtered via LINQ over activeJobs.Values
- JobsController generates Since timestamp, returns ChildrenResponse
instead of setting x-delta-timestamp header
- JobsService deserializes ChildrenResponse instead of parsing headers
Addressed all review comments from Fastwind (review #42):
x-delta-timestamp header removed — replaced with proper ChildrenResponse DTO that includes Children + Since
Tuple return type removed — JobManager.GetChildren now returns List<JobStatusDto> directly, DateTime.UtcNow moved to controller
ActiveJobs foreach converted to LINQ — activeJobs.Values.Where().Select() instead of manual loop
Parallel access concern acknowledged — ConcurrentDictionary.Values is thread-safe; the LINQ query enumerates at the call site
(commit 89c91b2)
Addressed all review comments from Fastwind (review #42):
1. **x-delta-timestamp header removed** — replaced with proper `ChildrenResponse` DTO that includes `Children` + `Since`
2. **Tuple return type removed** — `JobManager.GetChildren` now returns `List<JobStatusDto>` directly, `DateTime.UtcNow` moved to controller
3. **ActiveJobs foreach converted to LINQ** — `activeJobs.Values.Where().Select()` instead of manual loop
4. **Parallel access concern acknowledged** — `ConcurrentDictionary.Values` is thread-safe; the LINQ query enumerates at the call site
(commit `89c91b2`)
Fastwind
approved these changes 2026-07-10 15:43:47 +00:00
REDCODE
approved these changes 2026-07-10 15:48:46 +00:00
REDCODE
merged commit bc71887726 into develop2026-07-10 15:48:55 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fastwind
REDCODE
Fixes #76
Part 1: Subjob status reporting fix
Subjob status (all 4 slave jobs)
After the asset processing loop, the slave now checks
failedAssets:JobStatus.Fail(...)JobStatus.CompleteWithErrors(...)JobStatus.Complete(...)Previously all three cases called
JobStatus.Complete(...)unconditionally.Race condition fix (all 4 master Done handlers)
Replaced
failedAssets += sub.failedAssetswithInterlocked.Add(ref failedAssets, sub.failedAssets).Files:
Lactose/Jobs/PreviewJob.csLactose/Jobs/ThumbnailJob.csLactose/Jobs/MetadataJob.csLactose/Jobs/PHashJob.csPart 2: Jobs page UI redesign
Unified tabbed view
Search, filter, sort
bi-searchicon)EJobType+ All)EJobStatus+ All)Status summary strip
Job type badges
EJobType(inspired byAccessLevelBadgeon Users page)Mobile responsive
d-md-none): Compact card with icon, name, type badge, status dot, progress bar, elapsedTree spacing
ms-*indentationFiles:
MilkStream.Client/Components/Pages/Jobs.razor(rewritten)MilkStream.Client/Components/Pages/Jobs.razor.css(new)MilkStream.Client/Components/JobRow.razor(rewritten)MilkStream.Client/Components/JobTree.razor(updated)Testing needed
changes look fine, however there is a strange counting bug. A job with a single subjob that fails 12 assets, will show on the master job as 13 out of 12 failed.
WIP: fix: batch-processing subjobs report correct status on asset failures (#76)to fix: batch-processing subjob status reporting + redesign jobs page UI (#76)Addressed the double-counting bug — removed the
Interlocked.Increment(ref failedAssets)from the master Done handler in all 4 job types. The subjob'sfailedAssetsis now the sole source of truth, so 12 failed assets in a batch = 12 counted, no more +1 for the subjob status.Can we NOT push the damn compose file everytime?
@@ -56,7 +56,7 @@environment:# LactoseBaseUrl must be the address the *browser* can reach Lactose at.# Override this with your server's hostname/IP if not running on localhost.- LactoseBaseUrl=http://192.168.50.100:5162/This again?
Still a problem btw. This needs a revert.
- JobTree polls children for all Level 0 active roots (not just expanded), so segment progress bars update on collapsed rows too - Add PollChildren helper to deduplicate fetch logic - OnExpanded only stops refresh when no active roots remain - Store UtcNow as fallback when server x-delta-timestamp is missing - Fix segment colors: share ToCssClass between single and stacked bars, use text-bg-* classes for proper Bootstrap 5.3 progress-bar override - Replace status words with Bootstrap icons in child summary (e.g. "15 Running" → "15 🔃") for compact displaySee the relevant comments on open discussions
docker-compose.yml reverted to develop's LactoseBaseUrl=http://192.168.50.100:5162/
@@ -52,2 +54,3 @@if (accessLevel != EAccessLevel.Admin) { return Unauthorized(); }return Ok(jobManager.GetChildren(parentId));var (children, responseTime) = jobManager.GetChildren(parentId, since);Response.Headers["x-delta-timestamp"] = responseTime.ToString("O");headers should only be used for metadata around a request working, not as actual parameters for a query, if it is needed to handle a starting time, it should be passed as part of a DTO.
the specific "x-delta-timestamp" is used for profiling or time synced operations
this is more of a request to select a specific group of jobs, also may be used in conjunction with a "latest", for visualizing all the jobs inside a time window (can be used for debug feature)
@Ai_Agent the header isn't even in use and should be removed.
@@ -51,0 +51,4 @@/// <param name="parentId">The parent job ID.</param>/// <param name="since">If set, only children changed after this timestamp are returned. Null returns all children.</param>/// <returns>A tuple of children and the response timestamp to use for the next delta poll.</returns>public (List<JobStatusDto> Children, DateTime Since) GetChildren(Guid parentId, DateTime? since) {Because DateTime happens at the return, it can be directly generated from the caller of the method instead of being made every time, even if you may not care about the time.
Ttuple as return type make the code stinky because isn't cleanly hineritable. JobManager is actually a Service and it should follow the same policy of APIs so specific data structure should always be used to couple informations.
@Ai_Agent should be moved to the controller and keep the signature cleaner
@@ -54,3 +59,3 @@foreach (var job in activeJobs.Values) {if (job.ParentJobId == parentId) {results.Add(job.ToJobStatusDto());if (since is null || job.JobStatus.LastChange > since.Value) {The search may be long with a big list of jobs running; it could be favorable to use parallel access to the data structure.
@Ai_Agent Should probably be converted in a LINQ query.
Addressed all review comments from Fastwind (review #42):
ChildrenResponseDTO that includesChildren+SinceJobManager.GetChildrennow returnsList<JobStatusDto>directly,DateTime.UtcNowmoved to controlleractiveJobs.Values.Where().Select()instead of manual loopConcurrentDictionary.Valuesis thread-safe; the LINQ query enumerates at the call site(commit
89c91b2)