Samuele Lorefice

REDCODE approved MilkyShots/MilkyShots#55

2026-07-09 15:44:12 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

REDCODE suggested changes for MilkyShots/MilkyShots#55

2026-07-09 15:43:16 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

Awaiting fixes for PersonController/Get

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 15:42:49 +00:00

c1aafc4223 refactor: replace individual albumPage/albumSize params with PagedParametersDto in person detail endpoint

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 15:07:45 +00:00

a8d06959b5 feat: person hard delete with album cascade, AlbumCard select mode, cosplayer list multi-select

REDCODE commented on pull request MilkyShots/MilkyShots#55

2026-07-09 15:02:48 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

@Ai_Agent couple of changes required:

Person should not be a soft delete, but an hard delete. And on deletion, in cascade all the albums that have the id of the person being deleted should have…

REDCODE commented on pull request MilkyShots/MilkyShots#55

2026-07-09 14:51:19 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

@Ai_Agent don't use parameters from query, use a dedicated PaginationDto for this.

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:46:20 +00:00

dbbb25da32 fix: create AlbumSearchParametersDto, add album pagination to person detail, fix duplicate XML param

REDCODE suggested changes for MilkyShots/MilkyShots#55

2026-07-09 14:43:49 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

person controller retrieve all albums for a person doesn't have pagination options, it shoudl have, possibily in the same way albums is handled

REDCODE commented on pull request MilkyShots/MilkyShots#55

2026-07-09 14:43:16 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

@Ai_Agent this still needs to be fixed

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:40:35 +00:00

9f180742cd fix(test): update name assertion to match renamed person

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:38:44 +00:00

e8c1a80264 test: all tests create their own data — create album returns ID, all mutations use self-created resources

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:36:02 +00:00

7e16c77cb6 test: use real album from search for update test, not zero-GUID fallback

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:34:49 +00:00

8f6a4396db test: add album update test without removePerson field

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:32:48 +00:00

34fbbc91a0 chore(test): remove Swagger test — disabled in container environments

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:32:01 +00:00

9be49ac9c6 fix(test): use response.body directly instead of JSON.parse (already parsed object)

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:30:56 +00:00

c96b22fe62 fix(tests): fix pre-existing auth route tests and handle empty unassigned albums gracefully

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:26:12 +00:00

7f50d3c3e2 test(api): add comprehensive http tests for all person and album endpoints

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots

2026-07-09 14:22:53 +00:00

191cba4946 fix(pr): implement BulkUpdate, BulkDelete, revert docker-compose, explain [FromQuery]

REDCODE commented on pull request MilkyShots/MilkyShots#55

2026-07-09 14:19:54 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

Implementation of this?

REDCODE commented on pull request MilkyShots/MilkyShots#55

2026-07-09 14:19:54 +00:00

feat(ui): cosplayers pages — browse and discover cosplayers

Implementation of this?