Samuele Lorefice REDCODE
  • Joined on 2024-01-01
REDCODE commented on pull request MilkyShots/MilkyShots#55 2026-07-09 14:19:54 +00:00
feat(ui): cosplayers pages — browse and discover cosplayers

Implementation of this?

REDCODE commented on pull request MilkyShots/MilkyShots#55 2026-07-09 14:19:54 +00:00
feat(ui): cosplayers pages — browse and discover cosplayers

Implementation of this?

REDCODE suggested changes for MilkyShots/MilkyShots#55 2026-07-09 14:19:54 +00:00
feat(ui): cosplayers pages — browse and discover cosplayers

General review done. Holy heck the amount of lag from the removed SCSS files

REDCODE commented on pull request MilkyShots/MilkyShots#55 2026-07-09 14:12:53 +00:00
feat(ui): cosplayers pages — browse and discover cosplayers

There is no limit here, a prolific cosplayer with hundreds of albums will result in a very big object sent back as a response.

REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:56:21 +00:00
a38f627ca4 feat(dto): add RemovePerson flag to AlbumUpdateDto for explicit person unlinking
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:54:04 +00:00
f31b753182 refactor(dto): move Unassigned filter into PagedSearchParametersDto
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:19:05 +00:00
1377d02520 fix: prevent album title from being overwritten when only setting Person in update DTO
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:16:02 +00:00
bac1ad0afc fix(build): remove stray semicolon in onclick lambda
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:15:33 +00:00
1fd63dcb59 feat(ui): edit button on banner top-right, bulk album select/unlink mode, Add Albums always visible
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:12:36 +00:00
fa434b180d fix(api): allow unlinking person from album by directly assigning null PersonOwnerId
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:10:07 +00:00
4d169e6303 docs: add API reuse convention to AGENTS.md — prefer optional query params over new endpoints
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:09:11 +00:00
e1d7822b7c refactor(api): fold unassigned album filter into search endpoint via query param
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:07:20 +00:00
cc611828b9 feat(ui): unassigned album selector in PersonForm, Add Albums button in CosplayerDetail
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 13:00:53 +00:00
9aead51481 feat(ui): add New Cosplayer button on list page with create endpoint and form
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 12:56:50 +00:00
67d00efb10 fix(js): resize calculations now in viewport pixels to avoid image-relative X/Y scale mismatch on non-square images
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 12:51:00 +00:00
b71fef147a fix(js): skip resize on first mousemove if mouse hasn't moved from mousedown position
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 12:44:37 +00:00
8004dc2b43 fix(js): use correct opposite corners for TL/TR/BL resize handles
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 12:43:57 +00:00
c9f08ea48e fix(ui): use pixel-exact transform positioning for avatar display instead of background-size formula
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 12:32:13 +00:00
52b88a3ba4 fix(js): store cropZoom as image-relative fraction (square_side / image_displayed_width), no adjustment needed on save
REDCODE pushed to feature/cosplayers-pages at MilkyShots/MilkyShots 2026-07-09 12:15:19 +00:00
e39d753a85 fix(js): adjust stored cropZoom by image aspect ratio factor so background-size formula matches circle