REDCODE/CTI34-KPLIB-Ruha
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

WIP: fix: prevent group_diag from prematurely marking patrol groups for deletion #5

Draft
Fastwind wants to merge 1 commits from fix/patrol-group-lifecycle into master
pull from: fix/patrol-group-lifecycle
merge into: REDCODE:master
Conversation 0 Commits 1 Files Changed 2 +14
Fastwind commented 2026-07-03 14:44:43 +00:00
Collaborator
Copy Link

Tags patrol groups (KPLIB_patrol_group) so group_diag skips them, and
cleans up the tag + enables deleteGroupWhenEmpty only once the patrol
lifecycle is complete.

Tags patrol groups (KPLIB_patrol_group) so group_diag skips them, and cleans up the tag + enables deleteGroupWhenEmpty only once the patrol lifecycle is complete.
Fastwind added 1 commit 2026-07-03 14:44:43 +00:00
fix: prevent group_diag from prematurely marking patrol groups for deletion 4ff3e5107f 
Tags patrol groups (KPLIB_patrol_group) so group_diag skips them, and
cleans up the tag + enables deleteGroupWhenEmpty only once the patrol
lifecycle is complete. Prevents the '_grp was nil' log spam by fixing
the root cause rather than just silencin the symptom.
Fastwind requested review from REDCODE 2026-07-03 14:44:43 +00:00
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/patrol-group-lifecycle:fix/patrol-group-lifecycle
git checkout fix/patrol-group-lifecycle
Sign in to join this conversation.
Reviewers
No Reviewers
REDCODE
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Fastwind InHooman REDCODE
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: REDCODE/CTI34-KPLIB-Ruha#5
Delete Branch "fix/patrol-group-lifecycle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?